[POC] Catalog Views and integration with Service Manager

PK85 commented 9 months ago

Description

Provide new UI for BTP Operator in the Busola where users can see Service Catalog. For now it could be separate application, if installed in the Kyma cluster should already work. In the future probably it will be a part of the btp-manager module.

Reason

We want to make BTP Operator user's lives easier and more convenient where they can see all of the available services in the Busola and then just provision some of them.

AC

[ ] 1) Direct integration with the Service Manager
- [x] 1.1) User can use default credentials + can select secret from any namespace (SM credentials are from different SA and then could see different instances and service offerings) https://github.com/kyma-project/btp-manager/pull/655 https://github.com/kyma-project/btp-manager/pull/674 https://github.com/kyma-project/btp-manager/pull/703
- [x] 1.2) user can see a list of all service offerings from Service Manager from given SA (SM credentials are bound to given SA) https://github.com/kyma-project/btp-manager/pull/717
- [ ] 1.3) User can see a list of all existing instances from Service Manager from given SA (SM credentials are bound to given SA) https://github.com/kyma-project/btp-manager/pull/742
- [ ] 1.4) User can create a service binding on Service Manager side which results as a secret in the selected namespace in the Kyma environment
- [ ] 1.5) User can delete a service binding on Service Manager side which invalidates given secret (probably we need to delete corresponding secret)
[ ] 2) New BTP Operator UI in the Busola
- [ ] 2.1) check with Busola team, on how to embed our own web page (We should have a view in the namespace + in the overview taking into account all namespaces data)
[ ] Think in future of making it mobile - friendly Links
check smctl what calls are executed
https://github.com/Peripli/service-manager
https://help.sap.com/docs/service-manager/sap-service-manager/sap-service-manager

PK85 commented 9 months ago

Reference sharing:

apiVersion: services.cloud.sap.com/v1
kind: ServiceInstance
metadata:
  name: kyma-demo-instance-123
  namespace: develope
spec:
  serviceOfferingName: xsuaa
  servicePlanName: reference-instance
  parameters:
    referenced_instance_id: <shared service id>
---
apiVersion: services.cloud.sap.com/v1
kind: ServiceBinding
metadata:
  name: kyma-demo-binding-123
  namespace: develope
spec:
  serviceInstanceName: kyma-demo-instance-123

kyma-bot commented 6 months ago

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

kyma-bot commented 5 months ago

This issue or PR has been automatically closed due to the lack of activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

kyma-bot commented 5 months ago

@kyma-bot: Closing this issue.

In response to [this](https://github.com/kyma-project/btp-manager/issues/442#issuecomment-1888786355): >This issue or PR has been automatically closed due to the lack of activity. >Thank you for your contributions. > >This bot triages issues and PRs according to the following rules: >- After 60d of inactivity, `lifecycle/stale` is applied >- After 7d of inactivity since `lifecycle/stale` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle stale` > >If you think that I work incorrectly, kindly [raise an issue](https://github.com/kyma-project/test-infra/issues/new/choose) with the problem. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ukff commented 3 months ago

Issue with UI development for embedding pages: https://github.com/kyma-project/busola/issues/2762

szwedm commented 3 months ago

Meeting notes and current arrangements (3.04.24)

Arrangements:

support operations as in Service Manager
create REST API similar to Service Manager API (OSBAPI)
allow to connect Service Instances and Service Bindings from Service Manager to the cluster (custom resources in the cluster should reflect instances and bindings in SM)

Limitations:

Service Manager context is limited to the scope of SAP BTP service operator client provided during Kyma environment provisioning

Future ideas:

allow update of the cluster ID
service management as a BTP user (subaccount context)

ukff commented 2 months ago

early proposal of UI:

ukff commented 2 months ago

szwedm commented 2 months ago

SAP BTP service operator recognises the following secrets for service instances:

default secret named sap-btp-service-operator in the centrally managed namespace (kyma-system)
secret for a different subaccount mapped to a namespace in the cluster with namespace's name as a prefix in the secret's name <namespace-name>-sap-btp-service-operator in the centrally managed namespace (kyma-system)
secrets named sap-btp-service-operator in other namespaces mapped to different subaccounts
arbitrarily named secret in the centrally managed namespace (kyma-system) connected to a different subaccount pointed in the ServiceInstance btpAccessCredentialsSecret field in the spec

szwedm commented 2 months ago

PR introducing SecretProvider which fetches secrets with credentials for Service Manager: https://github.com/kyma-project/btp-manager/pull/655

szwedm commented 2 months ago

UI PR: https://github.com/kyma-project/btp-manager/pull/649

szwedm commented 1 month ago

Adding Service Manager client: https://github.com/kyma-project/btp-manager/pull/674

szwedm commented 1 month ago

Unit test for SM client service offerings: https://github.com/kyma-project/btp-manager/pull/703

ukff commented 1 month ago

Sprint review comments (21.05.2024):

Marketplace: ServiceOffering details + plans details
Marketplace: Search in UI
Marketplace: Create (PUT) Service Instances
SI: get number of instances for given secret
- Indicator is it on SM/Kyma or both (Postpone for next phase)
UI: Show error image
UI: Show loading image
Layout:
- reduce grey spaces
- make more wider
- make biggest card

ukff commented 4 weeks ago

Meeting notes 04.06.24

1: Service Manager resources (frontend needs backend first)

Marketplace: ServiceOffering details + plans details Backend (Marcin)
Marketplace: ServiceOffering details + plans details Frontend (Lukasz)
Marketplace: Create CRUD Service Instances Backend (Marcin)
Marketplace: Create (PUT) Service Instances Frontend (Lukasz)
SI: get service instances for given secret from SM Backend (Marcin)
SI: get service instances for given secret from SM Frontend (Lukasz)

2: Independent from backend:

Marketplace: Search in UI
UI: Show error image
UI: Show loading image
Layout:
- reduce grey spaces
- make more wider
- make biggest card

3:

Security to investigate how to restrict access to secrets for given users
Bundle backend and frontend without port conflicts (Marcin)
- Decide how to run everything together in 1 pod

szwedm commented 3 weeks ago

Marketplace: ServiceOffering details + plans details Backend (Marcin)

Done in https://github.com/kyma-project/btp-manager/pull/717

szwedm commented 2 weeks ago

Bundle backend and frontend without port conflicts (Marcin)

Decide how to run everything together in 1 pod

Done in: https://github.com/kyma-project/btp-manager/pull/720

ukff commented 1 week ago

UI: https://github.com/kyma-project/btp-manager/pull/728

szwedm commented 5 days ago

Marketplace: Create CRUD Service Instances Backend (Marcin)

Done in: https://github.com/kyma-project/btp-manager/pull/742

kyma-project / btp-manager

[POC] Catalog Views and integration with Service Manager #442

Meeting notes and current arrangements (3.04.24)