kyma-project / busola

Web based Kubernetes Dashboard with a focus on privacy that requires no active components or special privileges in your cluster.

Apache License 2.0

24 stars 48 forks source link

fix: always request `openid` scope from idp #3289

Closed v0lkc closed 2 weeks ago

v0lkc commented 3 weeks ago

Description

Changes proposed in this pull request:

busola shall always request the openid scope

Related issue(s)

3288

Definition of done

[x] The PR's title starts with one of the following prefixes:
- feat: A new feature
- fix: A bug fix
- docs: Documentation only changes
- refactor: A code change that neither fixes a bug nor adds a feature
- test: Adding tests
- chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
[x] Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
[ x Explain clearly why you created the PR and what changes it introduces
[x] All necessary steps are delivered, for example, tests, documentation, merging

kyma-bot commented 3 weeks ago

Hi @v0lkc. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

v0lkc commented 3 weeks ago

/test all

kyma-bot commented 3 weeks ago

@v0lkc: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kyma-project/busola/pull/3289#issuecomment-2304019218): >/test all Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

v0lkc commented 3 weeks ago

@mrCherry97 could you please have a look?

v0lkc commented 2 weeks ago

Closing, in favor of #3209