The Kyma CR can be deleted while Scope still exists, like when SKR cluster is deleted. Then we need to deactive that scope and SKR from the skrLooper and decease the cloud_manager_skr_runtime_module_active_count metrics. That metrics has labels "kymaName", "globalAccountId", "subAccountId", "shootName", "region", "brokerPlanName", where all but the first are not accessible anymore since Kyma was deleted. Hence, we need to copy those Kyma labels to Scope so that data is available at the time Scope is deleted and SKR deactivated so the proper metric can be decreased.
Changes proposed in this pull request:
added in scope.predicateScopeCreateOrUpdateNeeded a check if Kyma labels are copied
added in scope.ensureScopeCommonFields copying of Kyma labels
replaced skrruntime.ActiveSkrCollection methods AddKymaUnstructured and RemoveKymaUnstructured, with AddScope and RemoveScope
Description
The Kyma CR can be deleted while Scope still exists, like when SKR cluster is deleted. Then we need to deactive that scope and SKR from the skrLooper and decease the
cloud_manager_skr_runtime_module_active_countmetrics. That metrics has labels "kymaName", "globalAccountId", "subAccountId", "shootName", "region", "brokerPlanName", where all but the first are not accessible anymore since Kyma was deleted. Hence, we need to copy those Kyma labels to Scope so that data is available at the time Scope is deleted and SKR deactivated so the proper metric can be decreased.Changes proposed in this pull request:
scope.predicateScopeCreateOrUpdateNeededa check if Kyma labels are copiedscope.ensureScopeCommonFieldscopying of Kyma labelsskrruntime.ActiveSkrCollectionmethodsAddKymaUnstructuredandRemoveKymaUnstructured, withAddScopeandRemoveScopeRelated issue(s)