search

kyma-project / control-plane

A flexible and easy way to manage Kyma Runtimes
Apache License 2.0
17 stars 113 forks source link

Provisioner does not update Azure specific configuration correctly #3037

Open koala7659 opened 1 year ago

koala7659 commented 1 year ago

Description

The code for Azure NAT infra change to enable NAT gateway for existing runtimes is invalid and not used, but in some circonstances may cause problems to some migrated clusters:

https://github.com/kyma-project/control-plane/blob/main/components/provisioner/internal/model/gardener_config.go#L452-L489

Expected result

Remove obsolete code.

koala7659 commented 1 year ago

Quote from Slack thread where we analysed the code:

Basically there is nothing wrong with the code, it’s just for many runtimes the VNet CIDR was expanded during the HA migration and this was not reflected back in provisioner DB. This resulted in an undefined behaviour when executing that specific part of the code using stale input from DB vs changed infra config on shoot. Since the particular code was developed for NAT gateway enablement of existing SKRs which was never used and won’t be needed in the future, it is safe to remove this code to avoid future problems

koala7659 commented 1 year ago

More information can be found at control-plane issue 4387 in some internal Github

kyma-bot commented 10 months ago

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

You can:

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

kyma-bot commented 10 months ago

This issue or PR has been automatically closed due to the lack of activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

You can:

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

kyma-bot commented 10 months ago

@kyma-bot: Closing this issue.

In response to [this](https://github.com/kyma-project/control-plane/issues/3037#issuecomment-1806760379): >This issue or PR has been automatically closed due to the lack of activity. >Thank you for your contributions. > >This bot triages issues and PRs according to the following rules: >- After 60d of inactivity, `lifecycle/stale` is applied >- After 7d of inactivity since `lifecycle/stale` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle stale` > >If you think that I work incorrectly, kindly [raise an issue](https://github.com/kyma-project/test-infra/issues/new/choose) with the problem. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.