kyma-project / control-plane

A flexible and easy way to manage Kyma Runtimes
Apache License 2.0
16 stars 113 forks source link

Provisioner creates "istio-system" namespace as part of "create operator bindings" step #3415

Closed koala7659 closed 4 months ago

koala7659 commented 4 months ago

One of installed Kyma componenets "compass-runtime-agent" requires istio-system namespace to be correctly initialised. This namespace was created by the Provisioner as part of Runtime configuration step where Provisioner created secrets on the cluster that allowed to establish connection between compass-runtime-agent and Compass.

New version of the provisioner delivered by this PR makes Compass Registration process optional, controlled by env variables.

There was a bug in the code where after disabling Compass Registration - The Provisioner has stopped creating istio-system namespace as well.

This PR is suppose to mitigate this problem by moving namespace creation code into "create operator bindings" step

koala7659 commented 4 months ago

/test tide

kyma-bot commented 4 months ago

@koala7659: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kyma-project/control-plane/pull/3415#issuecomment-2010003988): >/test tide Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
koala7659 commented 4 months ago

/test all

kyma-bot commented 4 months ago

@koala7659: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-provisioner-e2e-tests 9d0443217255c711344e01288e92c9fa221df728 link false /test pre-main-provisioner-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).