kyma-project / control-plane

A flexible and easy way to manage Kyma Runtimes
Apache License 2.0
17 stars 112 forks source link

Central cleanup job for Shoot clusters on KCP DEV #3480

Open tobiscr opened 2 months ago

tobiscr commented 2 months ago

Description

We use currently two cleanup mechanisms for removing shoot-clusters on KCP DEV.

One is executed by KEB and removes Shoot-clusters which were created by KEB. Another job was running decoupled from KEB and removed shoot-clusters created by Provisioner.

To simplify the cleanup approach, a single cleanup job should be preferred. This job retrieves all Shoots from Gardener cluster and verifies whether they are known by KEB. If they are unknown, the cleanup mechanism will delete this cluster, independent who created it:

Created by Shoot deleted by cleanup job via
KEB KEB executes its deletion logic
KIM Removing the RuntimeCR
Gardener-UI Removing the Shoot-CR on Gardener cluster

The deletion has to consider the case, that a Shoot-CR can be marked with the label owner.do-not-delete: '<bool>'. Before a cluster is deleted, the cleanup job has to check the existence respectively the value of the label on the Shoot CR.

AC:

Reasons

Simplify KCP DEV housekeeping by centralising the shoot-cluster deletion job.

Attachments

tobiscr commented 1 month ago

@kyma-project/gopher / @PK85 - will you take it over?

tobiscr commented 1 week ago

@PK85 : thanks for referencing your issue. From Framefrog side, we won't work on this issue as it will be covered by https://github.com/kyma-project/kyma-environment-broker/issues/1417.

Thanks a lot!