Move status update

[pPrecel]

Description

Changes proposed in this pull request:

• move the status update to the end of the reconciliation. The goal of this PR is to update the status with the installed configuration when the registry is installed to avoid situations when the registry can't be installed because of any error but the status is already updated with no operational config
• set the Processing state only in the init state fn
• add two state fns updating status:
  • one that is updating the Configured condition
  • second that is updating the Installed condition and status fields

Related issue(s)

• https://github.com/kyma-project/docker-registry/issues/37#issue-2297243298

[pPrecel]

Here is full DockerRegistry CR lifecycle after applying it on the cluster:

kubectl get dockerregistry -oyaml -w
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11591968"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11591969"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
status:
  externalAccess: {}
  internalAccess: {}
  served: "True"
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11591970"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
status:
  externalAccess: {}
  internalAccess: {}
  served: "True"
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11591971"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
status:
  externalAccess: {}
  internalAccess: {}
  served: "True"
  state: Processing
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11591972"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
status:
  conditions:
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Configuration ready
    reason: Configured
    status: "True"
    type: Configured
  externalAccess: {}
  internalAccess: {}
  served: "True"
  state: Processing
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11592001"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
status:
  conditions:
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Configuration ready
    reason: Configured
    status: "True"
    type: Configured
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Installing for configuration
    reason: Installation
    status: Unknown
    type: Installed
  externalAccess: {}
  internalAccess: {}
  served: "True"
  state: Processing
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11592303"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
status:
  conditions:
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Configuration ready
    reason: Configured
    status: "True"
    type: Configured
  - lastTransitionTime: "2024-07-02T09:39:58Z"
    message: DockerRegistry installed
    reason: Installed
    status: "True"
    type: Installed
  externalAccess:
    enabled: "False"
  internalAccess:
    enabled: "True"
    pullAddress: localhost:32137
    pushAddress: dockerregistry.default.svc.cluster.local:5000
    secretName: dockerregistry-config
  served: "True"
  state: Ready
  storage: filesystem

And after updating spec:

kubectl get dockerregistry -oyaml -w
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 1
  name: default
  namespace: default
  resourceVersion: "11592303"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec: {}
status:
  conditions:
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Configuration ready
    reason: Configured
    status: "True"
    type: Configured
  - lastTransitionTime: "2024-07-02T09:39:58Z"
    message: DockerRegistry installed
    reason: Installed
    status: "True"
    type: Installed
  externalAccess:
    enabled: "False"
  internalAccess:
    enabled: "True"
    pullAddress: localhost:32137
    pushAddress: dockerregistry.default.svc.cluster.local:5000
    secretName: dockerregistry-config
  served: "True"
  state: Ready
  storage: filesystem
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 2
  name: default
  namespace: default
  resourceVersion: "11594274"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec:
  externalAccess:
    enabled: true
status:
  conditions:
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Configuration ready
    reason: Configured
    status: "True"
    type: Configured
  - lastTransitionTime: "2024-07-02T09:39:58Z"
    message: DockerRegistry installed
    reason: Installed
    status: "True"
    type: Installed
  externalAccess:
    enabled: "False"
  internalAccess:
    enabled: "True"
    pullAddress: localhost:32137
    pushAddress: dockerregistry.default.svc.cluster.local:5000
    secretName: dockerregistry-config
  served: "True"
  state: Ready
  storage: filesystem
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 2
  name: default
  namespace: default
  resourceVersion: "11594275"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec:
  externalAccess:
    enabled: true
status:
  conditions:
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Configuration ready
    reason: Configured
    status: "True"
    type: Configured
  - lastTransitionTime: "2024-07-02T09:39:58Z"
    message: DockerRegistry installed
    reason: Installed
    status: "True"
    type: Installed
  externalAccess:
    enabled: "False"
  internalAccess:
    enabled: "True"
    pullAddress: localhost:32137
    pushAddress: dockerregistry.default.svc.cluster.local:5000
    secretName: dockerregistry-config
  served: "True"
  state: Processing
  storage: filesystem
---
apiVersion: operator.kyma-project.io/v1alpha1
kind: DockerRegistry
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operator.kyma-project.io/v1alpha1","kind":"DockerRegistry","metadata":{"annotations":{},"name":"default","namespace":"default"},"spec":{}}
  creationTimestamp: "2024-07-02T09:39:33Z"
  finalizers:
  - dockerregistry-operator.kyma-project.io/deletion-hook
  generation: 2
  name: default
  namespace: default
  resourceVersion: "11594293"
  uid: acc31f01-5cc9-4cc4-b7f8-1e667512f6cf
spec:
  externalAccess:
    enabled: true
status:
  conditions:
  - lastTransitionTime: "2024-07-02T09:39:33Z"
    message: Configuration ready
    reason: Configured
    status: "True"
    type: Configured
  - lastTransitionTime: "2024-07-02T09:39:58Z"
    message: DockerRegistry installed
    reason: Installed
    status: "True"
    type: Installed
  externalAccess:
    enabled: "True"
    pullAddress: registry-default-default.c-2578af7.stage.kyma.ondemand.com
    pushAddress: registry-default-default.c-2578af7.stage.kyma.ondemand.com
    secretName: dockerregistry-config-external
  internalAccess:
    enabled: "True"
    pullAddress: localhost:32137
    pushAddress: dockerregistry.default.svc.cluster.local:5000
    secretName: dockerregistry-config
  served: "True"
  state: Ready
  storage: filesystem