search

kyma-project / eventing-auth-manager

Apache License 2.0
1 stars 7 forks source link

chore: Bump Go version in mod file #129

Closed friedrichwilken closed 6 months ago

friedrichwilken commented 7 months ago

Blocked: https://github.com/kyma-project/eventing-auth-manager/pull/129#issuecomment-1956059555

Description

Changes proposed in this pull request:

Related issue(s) none

friedrichwilken commented 7 months ago

It looks like the Docker-in-Docker image we use for the pull-eventing-auth-manager-integration-test job is outdated and cannot support Go >=v1.22.0. So we might need to wait until a newer image is available in the registry.

k15r commented 7 months ago

It looks like the Docker-in-Docker image we use for the pull-eventing-auth-manager-integration-test job is outdated and cannot support Go >=v1.22.0. So we might need to wait until a newer image is available in the registry.

maybe this here fixes the situation: https://github.com/kyma-project/eventing-auth-manager/pull/131

mfaizanse commented 6 months ago

/test all

mfaizanse commented 6 months ago

/test all

friedrichwilken commented 6 months ago

/test pull-eventing-auth-manager-integration-test

kyma-bot commented 6 months ago

@friedrichwilken: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-eventing-auth-manager-integration-test 2d35676b8736256a139e87b155a9d4cc8795ccb2 link true /test pull-eventing-auth-manager-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
friedrichwilken commented 6 months ago

It looks like the Docker-in-Docker image we use for the pull-eventing-auth-manager-integration-test job is outdated and cannot support Go >=v1.22.0. So we might need to wait until a newer image is available in the registry.

maybe this here fixes the situation: #131

unfortunately we still get this:

Error: load packages in root "/home/prow/go/src/github.com/kyma-project/eventing-auth-manager": err: exit status 1: stderr: go: go.mod requires go >= 1.22.0 (running go 1.21.4; GOTOOLCHAIN=local)

event with the newest image.

friedrichwilken commented 6 months ago

This PR would provide the dind image with the needed go version 1.22.0. After this was merged, we need to bump the dind image we use for the pull-eventing-auth-manager-integration-test here. This should then fix the failing test.

Update: the aforementioned PR fails a test and we need to find out why.