search

kyma-project / eventing-manager

Eventing Operator installs Eventing as Kyma module
Apache License 2.0
5 stars 15 forks source link

Set warning to Eventing CR state if EventMesh secret is malformatted #490

Closed muralov closed 6 months ago

muralov commented 7 months ago

Description

If a user provides not proper EventMesh secret in case of EventMesh backend, the eventing CR has error state. However, it needs to have warning as it is a user caused error.

Expected result Eventing CR status:

   ...
    - lastTransitionTime: "2024-02-09T13:37:36Z"
      message: 'invalid EventMesh secret for Event Publisher:
        messaging is missing from EM secret'
      reason: EventMeshSubscriptionManagerFailed
      status: "False"
      type: SubscriptionManagerReady
  state: Warning

Actual result Eventing CR status:

   ...
    - lastTransitionTime: "2024-02-09T13:37:36Z"
      message: 'failed to sync Publisher Proxy secret: invalid secret for Event Publisher:
        messaging is missing from EM secret'
      reason: EventMeshSubscriptionManagerFailed
      status: "False"
      type: SubscriptionManagerReady
  state: Error

Steps to reproduce make wrong event mesh secret format

k15r commented 6 months ago

https://github.com/kyma-project/eventing-manager/pull/511