Set force-deletion flag when creating shoot-cluster [KIM/feature]

kyma-project / infrastructure-manager

Apache License 2.0

0 stars 9 forks source link

Set force-deletion flag when creating shoot-cluster [KIM/feature] #103

Open tobiscr opened 7 months ago

tobiscr commented 7 months ago

Description

Gardner supports now the option to force the deletion of a cluster (which avoids longer waiting-periods during the de-provisioning e.g. the K8s cluster couldn't be gracefully stopped caused by hanging finalizers).

We agreed to use this feature flag and the infrastructure manager / provisioner should set this flag properly.

AC:

[ ] The annotation confirmation.gardener.cloud/force-deletion is set in the shoot-specs of Gardener clusters.

Reasons

Enable/accept non-graceful shutdowns of Gardener clusters to avoid longer waiting periods during the de-provisioning.

Attachments

https://gardener.cloud/docs/gardener/shoot_operations/#force-deletion

[Moved from Provisioner to KIM]

tobiscr commented 4 months ago

Pre-requisite for https://github.com/kyma-project/kyma/issues/18198

Disper commented 4 days ago

@tobiscr should that annotation be set for only new clusters or should also existing clusters be migrated at some point? E.g. should the migrator also add that annotation to the Runtime CRs it creates?

Disper commented 3 days ago

Confirmed that we want to set it only for new clusters.

Disper commented 3 days ago

According to what I've tried - it's not possible to just create a cluster with that annotation set.

This is only possible if the Shoot fails to be deleted normally.

For more details, please refer to the relevant Gardener docu.

It could be possible to do it differently and when we fail to delete a cluster with one of those listed error messages to apply the annotation then.

tobiscr commented 21 hours ago

JFYI - @pbochynski :

After deeper investigation, we realised that this features collides with #126 :

The deletion flag becomes obsolete when we support the hibernation of clusters as save-deletion-approach
We recommend to postpone this feature until we have #126 implemented. For the house-keeping we can still consider the force-deletion option.

pbochynski commented 19 hours ago

Yes - we can postpone this one. We should also check how Gardener handles the deletion of hibernated clusters. Maybe the force-deletion annotation will help to reduce the time.