search

kyma-project / kyma

Kyma is an opinionated set of Kubernetes-based modular building blocks, including all necessary capabilities to develop and run enterprise-grade cloud-native applications.
https://kyma-project.io
Apache License 2.0
1.52k stars 405 forks source link

istio-proxy-reset job doesn't restart function and eventing controller deployments #10730

Closed ebensom closed 3 years ago

ebensom commented 3 years ago

Description

The istio-proxy-reset job doesn't seem to have any effect on specific workloads created by either the eventing controller or the function controller .

The kubectl rollout restart command used by the istio-proxy-reset script works by changing an annotation in the deployment pod spec, however the annotations are controlled by the controller, and immediately rolled back. For example: https://github.com/kyma-project/kyma/blob/274bac2906a69feed1e516f879ba34fa8de7d144/components/function-controller/internal/controllers/serverless/deployment.go#L100

Solution could be to change the behavior of the function and eventing controllers to omit external annotations, or adapt the istio-proxy-reset script to forcefully delete these pods instead of restarting them.

Steps to reproduce

Issue kubectl rollout restart on any deployment created by either the function controller or eventing controller.

a-thaler commented 3 years ago

We should solve it properly by adjusting the controllers. Everyone will expect to have the rollout command working properly I assume.

sayanh commented 3 years ago

@ebensom Why do you think it is done in the eventing-controller?

kwiatekus commented 3 years ago

@aerfio fixed the annotation handling on serverless deployments

sayanh commented 3 years ago

This does not impact eventing controllers.

ghost commented 3 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

strekm commented 3 years ago

@k15r is it done? is there something that needs to be implemented in istio-proxy-reset job?

k15r commented 3 years ago

@strekm according to @sayanh we are not impacted.

ghost commented 3 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

ghost commented 3 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

mjakobczyk commented 3 years ago

istio-proxy-reset job has been rewritten to the Golang code. We also removed entire istio chart and introduced a brand-new Istio-configuration. If @sayanh states that we are not affected then I assume there is no work to be done anyways.