search

kyma-project / kyma

Kyma is an opinionated set of Kubernetes-based modular building blocks, including all necessary capabilities to develop and run enterprise-grade cloud-native applications.
https://kyma-project.io
Apache License 2.0
1.51k stars 404 forks source link

Sort out Application Connector dependencies #11826

Closed franpog859 closed 1 year ago

franpog859 commented 3 years ago

Context

~~First thing: Application Connector consists of a number of components. All of their charts you should find there. What is more, I'd say that Compass Runtime Agent also is a part of the Application Connector as it takes some of the open-source Application Connector components' responsibility in the Compass mode. Anyway, these components are nicely structured in the mentioned resources/ directory but not so great in the components/ one~~ Moved to https://github.com/kyma-project/kyma/issues/12349

Second thing: Application Connector chart cannot be installed on its own because it won't work. We didn't dig into it much deeper so I cannot say why. It shouldn't be that way in the world of microservices

Problem

We may consider moving all of the Application Connector components into one folder under the components/ directory and build binaries using the same sources. It'll make the code easier to reuse. It'll also speed up bumping libraries and fixing security vulnerabilities

We also want to make Application Connector a really microservicy bundle. So it could be installed and run without other microservices or using only their interfaces. That's good for the testing purposes (will enable to test Application Connector in a fast manner), fast development process (as there are much fewer dependencies on other components) and maybe rolling updates in the future

Discussed solutions

Feel free to take part in the discussion, propose another solution and create acceptance criteria below. We may also consider splitting up these two things into two issues as they are not really super related

ghost commented 2 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

mvshao commented 2 years ago

Hi @franpog859 ✋🏻 I split first thing into a new issue kyma-project/kyma#12349

franpog859 commented 2 years ago

Consider also these:

I think all of these could be combined as a third thing, so feel free to create a separate issue for it if you wish

janmedrek commented 2 years ago

Hey @franpog859, I have edited the issue name to reflect what you have described as "the second thing". Let's focus on sorting out the dependencies in this issue and move all the rest to the one that @mvshao created and the Epic for the cleanup: https://github.com/kyma-project/kyma/issues/12353

franpog859 commented 2 years ago

I created a separate issue for the third thing just to keep it easy to track. Here it is

ghost commented 2 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

janmedrek commented 2 years ago

The obvious part is that Istio is a requirement we cannot get rid of. We want to make Application Connector independent of other Kyma components (Service Catalog, Eventing, etc.).

We can also think of separating the AC chart into istio and non-istio parts (as a follow-up).

ghost commented 2 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

ghost commented 2 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

akgalwas commented 1 year ago

It will be handles as a part of #15826