search

kyma-project / kyma

Kyma is an opinionated set of Kubernetes-based modular building blocks, including all necessary capabilities to develop and run enterprise-grade cloud-native applications.
https://kyma-project.io
Apache License 2.0
1.51k stars 407 forks source link

Use semantic versioning for kyma modules (managers) #18410

Open pbochynski opened 7 months ago

pbochynski commented 7 months ago

Description

According to the modularization concept modules artifacts should use semantic versioning (semver.org). This requirement was fulfilled by the front runners modules, but is not consequently applied by other modules. Here are the latest released versions of module managers (operators):

Expected result All modules use semantic versioning

Actual result

Steps to reproduce

Troubleshooting

Disper commented 7 months ago

@koala7659, @m00g3n, I thought that we already switched to semver with 1.0.3. Could you have a look?

koala7659 commented 7 months ago

@pbochynski We use semantic versioning for application-connector-module. Version 1.0.3 is available in both fast and regular channel

Disper commented 7 months ago

@pbochynski could you elaborate where the ACM is not using semver?

pbochynski commented 7 months ago

@Disper When you look into the released deployment you can find that the operator is in version:

europe-docker.pkg.dev/kyma-project/prod/application-connector-manager:v20231106-bfc94e9f

If you want to check which version is applied in your cluster you have to download the yaml file from release artifacts and check what is inside. If the version matches your deployment then you know the version. Wouldn't it be easier if you follow the pattern we established with the modularization front runners (keda, btp-manager, serverless) and use semantic versioning for module manager?

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

a-thaler commented 1 month ago

@Disper application-connector-manager is still not following that convention

tobiscr commented 1 month ago

@a-thaler : we will pick it up as part of our release process automation and fix it in coming sprint(s). Have to see how fast we can implement the process, but we have it on the radar. Issue for release process automation is https://github.com/kyma-project/application-connector-manager/issues/104.

tobiscr commented 2 weeks ago

fix for ACM ready, see:

https://console.cloud.google.com/artifacts/docker/kyma-project/europe/prod/application-connector-manager/sha256:039b081aa205dc66e8d7b6a9176c85dcbcb536facf0b382275aabbf5692e26af