search

kyma-project / kyma

Kyma is an opinionated set of Kubernetes-based modular building blocks, including all necessary capabilities to develop and run enterprise-grade cloud-native applications.
https://kyma-project.io
Apache License 2.0
1.51k stars 404 forks source link

[Service Catalog] Brokers with names longer than 63 chars are not accepted #6132

Closed mszostok closed 4 years ago

mszostok commented 4 years ago

Bug Report

What happened:

After registering our broker it is in status ErrorSyncingCatalog

svcat describe broker sm-enterprise-messaging-service-broker-eeb7858e-01c5-42ae-93cd-ac20625bd040                                    https://service-manager.cfapps.com/v1/osb/eeb7858e-01c5-42ae-93cd-ac20625bd040   ErrorSyncingCatalo

  Name:     sm-enterprise-messaging-service-broker-eeb7858e-01c5-42ae-93cd-ac20625bd040                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            

  Scope:    cluster                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                

  URL:      https://service-manager.cfapps.com/v1/osb/eeb7858e-01c5-42ae-93cd-ac20625bd040                                                                                                                                                                                                                                                                                                                                                                                                                                                                      

  Status:   ErrorSyncingCatalog - Error syncing catalog from ClusterServiceBroker.Error reconciling ClusterServiceClass (K8S: "588f637e-5de8-4b60-8fda-8d9015c55052" ExternalName: "enterprise-messaging") (broker "sm-enterprise-messaging-service-broker-eeb7858e-01c5-42ae-93cd-ac20625bd040"): ClusterServiceClass.servicecatalog.k8s.io "588f637e-5de8-4b60-8fda-8d9015c55052" is invalid: metadata.labels: Invalid value: "sm-enterprise-messaging-service-broker-eeb7858e-01c5-42ae-93cd-ac20625bd040": must be no more than 63 characters @ 2019-10-24 12:18:42 +0000 UTC

What you expected to happen: Broker status is Ready

How to reproduce it (as minimally and precisely as possible): Register a service broker with name longer than 63 chars

Anything else we need to know?:

Environment:

official issue: https://github.com/kubernetes-sigs/service-catalog/issues/2736

mszostok commented 4 years ago

This issue was raised by the Service Manager team. They need to because of the SM strategy for registering the underlying brokers

stale[bot] commented 4 years ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed due to the lack of recent activity.

PK85 commented 4 years ago

@mszostok I think we already do that on Service Catalog side. Please let me know if not.