search

kyma-project / kyma

Kyma is an opinionated set of Kubernetes-based modular building blocks, including all necessary capabilities to develop and run enterprise-grade cloud-native applications.
https://kyma-project.io
Apache License 2.0
1.51k stars 405 forks source link

Helm3 support for logging component #8601

Closed a-thaler closed 4 years ago

a-thaler commented 4 years ago

Description Migrate the logging component to be helm3 compliant

AC:

Reasons Support for Helm3 in Kyma

Attachments

clebs commented 4 years ago

The logging chart has been migrated to helm 3 except for 2 points that will be done later for all components:

That can be done once https://github.com/kyma-project/kyma/issues/8517 is finished and applied into the Prow jobs.

rakesh-garimella commented 4 years ago

While trying to install monitoring charts using helm install I get following error(although helm template does not complain):

label validation error: key "app.kubernetes.io/managed-by" must equal "Helm": current value is "Tiller"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "monitoring"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "default"

I think we need to add app.kubernetes.io/managed-by:Helm currently its Tiller and "meta.helm.sh/release-name" and "meta.helm.sh/release-namespace" is missing may be we need such changes too here ?

a-thaler commented 4 years ago

@rakesh-garimella Was there a monitoring chart already installed before via helm2? Reading this link it sounds like you can use these annotations for migration purposes: https://github.com/helm/helm/pull/7649 Please figure out what the effect of these annotations and labels is and if that is the best practice for writing helm charts, then we can think of applying that consistently to all.