kyma-project / kyma

Kyma is an opinionated set of Kubernetes-based modular building blocks, including all necessary capabilities to develop and run enterprise-grade cloud-native applications.
https://kyma-project.io
Apache License 2.0
1.52k stars 405 forks source link

MinIO Gateway mode is broken in 1.14^ #9335

Closed magicmatatjahu closed 4 years ago

magicmatatjahu commented 4 years ago

Description

As in title: MinIO Gateway mode in Rafter is broken in 1.14^

AC:

Errors on upgrade phase (migration from persistence mode to gateway mode):

2020/08/27 09:24:06 [debug] error updating the resource "rafter-minio": cannot patch "rafter-minio" with kind Deployment: "" is invalid: patch: Invalid value: "{\"apiVersion\":\"apps/v1\",\"kind\":\"Deployment\",\"metadata\":{\"annotations\":{\"deployment.kubernetes.io/revision\":\"2\",\"meta.helm.sh/release-name\":\"rafter\",\"meta.helm.sh/release-namespace\":\"kyma-system\"},\"creationTimestamp\":\"2020-08-24T11:00:32Z\",\"generation\":2,\"labels\":{\"app\":\"minio\",\"app.kubernetes.io/managed-by\":\"Helm\",\"chart\":\"minio-3.0.1\",\"heritage\":\"Helm\",\"release\":\"rafter\"},\"name\":\"rafter-minio\",\"namespace\":\"kyma-system\",\"resourceVersion\":\"1602015\",\"uid\":\"d955fd10-30d0-4795-860b-46bebb04d16d\"},\"spec\":{\"progressDeadlineSeconds\":600,\"replicas\":2,\"revisionHistoryLimit\":10,\"selector\":{\"matchLabels\":{\"app\":\"minio\",\"release\":\"rafter\"}},\"strategy\":{\"type\":\"RollingUpdate\",\"rollingUpdate\":{\"maxUnavailable\":\"50%\",\"maxSurge\":0}},\"template\":{\"metadata\":{\"annotations\":{\"checksum/config\":\"aa134769c859ae00eee77f79d56c8a28e22480fca2610792cfb64197446b5f39\",\"checksum/secrets\":\"028ef37e86ccbaf1f54169ba59e40e75795e477f771d09f154b220b932e4e39c\",\"persistence\":false,\"sidecar.istio.io/inject\":\"false\"},\"creationTimestamp\":null,\"labels\":{\"app\":\"minio\",\"release\":\"rafter\"},\"name\":\"rafter-minio\"},\"spec\":{\"volumes\":[{\"name\":\"minio-user\",\"secret\":{\"secretName\":\"rafter-minio\",\"defaultMode\":420}},{\"name\":\"minio-config-dir\",\"emptyDir\":{}}],\"containers\":[{\"name\":\"minio\",\"image\":\"eu.gcr.io/kyma-project/incubator/develop/minio/minio:RELEASE.2019-10-12T01-39-57Z-a67baaa0\",\"command\":[\"/bin/sh\",\"-ce\",\"/usr/bin/docker-entrypoint.sh minio -C /root/.minio/ gateway gcs sap-cx-faros-integration\"],\"ports\":[{\"name\":\"http-service\",\"containerPort\":9000,\"protocol\":\"TCP\"}],\"env\":[{\"name\":\"MINIO_ACCESS_KEY\",\"valueFrom\":{\"secretKeyRef\":{\"name\":\"rafter-minio\",\"key\":\"accesskey\"}}},{\"name\":\"MINIO_SECRET_KEY\",\"valueFrom\":{\"secretKeyRef\":{\"name\":\"rafter-minio\",\"key\":\"secretkey\"}}},{\"name\":\"GOOGLE_APPLICATION_CREDENTIALS\",\"value\":\"/etc/credentials/gcs_key.json\"},{\"name\":\"MINIO_BROWSER\",\"value\":\"off\"},{\"name\":\"MINIO_PROMETHEUS_AUTH_TYPE\",\"value\":\"public\"}],\"resources\":{\"limits\":{\"cpu\":\"100m\",\"memory\":\"128Mi\"},\"requests\":{\"cpu\":\"10m\",\"memory\":\"32Mi\"}},\"volumeMounts\":[{\"name\":\"minio-user\",\"readOnly\":true,\"mountPath\":\"/etc/credentials\"},{\"name\":\"minio-config-dir\",\"mountPath\":\"/root/.minio/\"}],\"livenessProbe\":{\"httpGet\":{\"path\":\"/minio/health/live\",\"port\":\"http-service\",\"scheme\":\"HTTP\"},\"initialDelaySeconds\":5,\"timeoutSeconds\":1,\"periodSeconds\":30,\"successThreshold\":1,\"failureThreshold\":3},\"readinessProbe\":{\"httpGet\":{\"path\":\"/minio/health/ready\",\"port\":\"http-service\",\"scheme\":\"HTTP\"},\"initialDelaySeconds\":5,\"timeoutSeconds\":1,\"periodSeconds\":15,\"successThreshold\":1,\"failureThreshold\":3},\"terminationMessagePath\":\"/dev/termination-log\",\"terminationMessagePolicy\":\"File\",\"imagePullPolicy\":\"IfNotPresent\"}],\"restartPolicy\":\"Always\",\"terminationGracePeriodSeconds\":30,\"dnsPolicy\":\"ClusterFirst\",\"serviceAccountName\":\"rafter-minio\",\"serviceAccount\":\"rafter-minio\",\"securityContext\":{},\"schedulerName\":\"default-scheduler\"}}},\"status\":{\"observedGeneration\":2,\"replicas\":2,\"updatedReplicas\":2,\"unavailableReplicas\":2,\"conditions\":[{\"type\":\"Progressing\",\"status\":\"True\",\"lastUpdateTime\":\"2020-08-27T09:07:39Z\",\"lastTransitionTime\":\"2020-08-24T11:00:32Z\",\"reason\":\"NewReplicaSetAvailable\",\"message\":\"ReplicaSet \\"rafter-minio-577595fd67\\" has successfully progressed.\"},{\"type\":\"Available\",\"status\":\"False\",\"lastUpdateTime\":\"2020-08-27T09:21:47Z\",\"lastTransitionTime\":\"2020-08-27T09:21:47Z\",\"reason\":\"MinimumReplicasUnavailable\",\"message\":\"Deployment does not have minimum availability.\"}]}}": v1.Deployment.Spec: v1.DeploymentSpec.Template: v1.PodTemplateSpec.ObjectMeta: v1.ObjectMeta.Annotations: ReadString: expects " or n, but found f, error found in #10 byte of ...|istence":false,"side|..., bigger context ...|5795e477f771d09f154b220b932e4e39c","persistence":false,"sidecar.istio.io/inject":"false"},"creationT|...

magicmatatjahu commented 4 years ago

Fixed by https://github.com/kyma-project/kyma/pull/9369