kyma-project / kyma

Kyma is an opinionated set of Kubernetes-based modular building blocks, including all necessary capabilities to develop and run enterprise-grade cloud-native applications.
https://kyma-project.io
Apache License 2.0
1.51k stars 405 forks source link

The pod-preset webhook client creation #9350

Closed crabtree closed 4 years ago

crabtree commented 4 years ago

Description

The current approach creates the connection on every request which leads to multiple queries to the API server. In certain cases, it leads to timeouts, and pod-presets are not applied. The fix moves the client creation to the component initialization and then reuses it during all calls.

Expected result

The client is reused between calls.

Actual result

The new client is created for every resource processing.

Steps to reproduce

Troubleshooting

crabtree commented 4 years ago

Solved in: https://github.com/kyma-incubator/podpreset-crd/pull/7 https://github.com/kyma-project/kyma/pull/9310