kyma-project / lifecycle-manager

Controller that manages the lifecycle of Kyma Modules in your cluster.
http://kyma-project.io
Apache License 2.0
10 stars 30 forks source link

[Deletion Modes] Introduce associatedResources field to Manifest Spec #1582

Closed nesmabadr closed 4 months ago

nesmabadr commented 5 months ago

Description

In order to support https://github.com/kyma-project/lifecycle-manager/issues/1211, we need to have the associatedResources saved in the ManifestSpec.

Reasons

To support managed resources, we need the associatedResources field so that it can be used to determine which resources are managed and need to be deleted first from the SKR Cluster.

Acceptance Criteria

Example Manifest CR:

[...]
spec:
  install:
    name: raw-manifest
    source:
      [...]
  remote: true
  resource:
    apiVersion: operator.kyma-project.io/v1alpha1
    kind: Sample
    metadata:
      name: sample-yaml
      namespace: kyma-system
    spec:
      resourceFilePath: ./module-data/yaml
  associatedResources: 
     - serverless.kyma-project.io/v1alpha2/functions
     - operator.kyma-project.io/v1alpha1/serverlesses
  version: 1.1.1

Feature Testing

No response

Testing approach

No response

Attachments

No response

nesmabadr commented 1 month ago

This field was reverted in this PR since it is no longer needed for the modules deletion feature