kyma-project / lifecycle-manager

Controller that manages the lifecycle of Kyma Modules in your cluster.
http://kyma-project.io
Apache License 2.0
10 stars 30 forks source link

KymaCR.status.modules not updated on module disabling #1762

Open c-pius opened 1 month ago

c-pius commented 1 month ago

Description

When disabling a module, the module's manifest gets deleted quite swiftly. Watcher logs also indicate that the change is sent from SKR to KCP immediately. However, even after the manifest got deleted, the KymaCR still lists the module under .status.modules[] in Ready state, seemingly until the next scheduled requeue. When this requeue happens, the entry is fully removed from .status.modules[]. When adding a module, the change is immediately reflected in .status.modules[].

Steps to reproduce

reproducable on DEV, STAGE and PROD

Environment Type

Managed

Environment Info

Kubernetes Version: x.y.z Docker Version: x.y.z Kyma CLI Version: x.y.z If used - k3d/k3s/minikube versions

Acceptance Criterias

jeremyharisch commented 1 month ago

To address this, I suggest that when the Kyma Reconcile loop sends a request to the Kubernetes API (i.e. to delete a Manifest CR), the corresponding Kyma CR should be set into a Processing state. This approach would likely trigger more frequent reconciliation, leading to earlier updates in the Kyma CR status. Additionally, this would clearly indicate that the Kyma instance is still processing changes, rather than incorrectly appearing as fully Ready.