kyma-project / lifecycle-manager

Controller that manages the lifecycle of Kyma Modules in your cluster.
http://kyma-project.io
Apache License 2.0
10 stars 30 forks source link

[ModuleCatalog] Implement Logic for `ModuleReleaseMeta` CRD in Kyma Reconcile Loop #1849

Closed jeremyharisch closed 3 weeks ago

jeremyharisch commented 2 months ago

Description:

We need to implement the logic to utilize the newly created ModuleReleaseMeta CRD in the Kyma reconcile loop. Currently, we fetch and filter ModuleTemplates based on the channel specified in ModuleTemplate.spec. This logic needs to be updated to fetch the appropriate ModuleTemplate by using the information from the ModuleReleaseMeta CRD.

Detailed decision ticket: https://github.com/kyma-project/lifecycle-manager/issues/1815

New Logic:

Acceptance Criteria:

c-pius commented 1 month ago

ModuleReleaseMeta CRs should be cached using a TTL cache

Can we really cache it? When it changes, we enqueue a reconcile event for the related kymas which should then fetch the up to date version, and not a maybe outdated one from the cache

Consider introducing a naming pattern for ModuleReleaseMeta to simplify the fetching process. If this is decided upon, the naming pattern needs to be well-documented.

I think the naming pattern must already be defines as part of https://github.com/kyma-project/lifecycle-manager/issues/1848. But I think it can be as simple as the module name?

janmedrek commented 1 month ago

Depends on: https://github.com/kyma-project/lifecycle-manager/issues/1848

nesmabadr commented 2 weeks ago

Verified this on dev, since no modules use the modulereleasemeta yet.