Closed jeremyharisch closed 3 weeks ago
ModuleReleaseMeta CRs should be cached using a TTL cache
Can we really cache it? When it changes, we enqueue a reconcile event for the related kymas which should then fetch the up to date version, and not a maybe outdated one from the cache
Consider introducing a naming pattern for ModuleReleaseMeta to simplify the fetching process. If this is decided upon, the naming pattern needs to be well-documented.
I think the naming pattern must already be defines as part of https://github.com/kyma-project/lifecycle-manager/issues/1848. But I think it can be as simple as the module name?
Verified this on dev, since no modules use the modulereleasemeta yet.
Description:
We need to implement the logic to utilize the newly created
ModuleReleaseMeta
CRD in the Kyma reconcile loop. Currently, we fetch and filterModuleTemplates
based on the channel specified inModuleTemplate.spec
. This logic needs to be updated to fetch the appropriateModuleTemplate
by using the information from theModuleReleaseMeta
CRD.Detailed decision ticket: https://github.com/kyma-project/lifecycle-manager/issues/1815
New Logic:
ModuleTemplates
and filtering by the channel specified inModuleTemplate.spec
, first fetch theModuleReleaseMeta
CR.Kyma.spec
for the module.ModuleReleaseMeta.spec
.ModuleTemplate
based on this version.ModuleReleaseMeta
to simplify the fetching process, it needs to be well-documented (just the module name).ModuleTemplate
CRs as well (modulename-versionnumber)Acceptance Criteria:
ModuleReleaseMeta
for fetchingModuleTemplates
.ModuleReleaseMeta
, including any naming patterns introduced.