kyma-project / lifecycle-manager

Controller that manages the lifecycle of Kyma Modules in your cluster.
http://kyma-project.io
Apache License 2.0
10 stars 30 forks source link

Align runtime-watcher image names #1859

Open c-pius opened 6 days ago

c-pius commented 6 days ago

Description

We use different image names for runtime-watcher in Dev and Prod registries: https://github.com/kyma-project/lifecycle-manager/blob/2ad71ddeb13f42e5a6db022404079f32d6fd8a41/cmd/main.go#L358-L361

Recently, when adapting build pipelines, we confused things up already. We should align the name and use the same for both registries.

Reasons

Consistency and less prone to mistakes

Acceptance Criteria

Feature Testing

No response

Testing approach

No response

Attachments

No response

c-pius commented 6 days ago

Prio to be discussed. We may need to have it fixed before the next watcher release.

c-pius commented 4 days ago

updated pipelines to build the image using the common name

watcher is now uniformely built with runtime-watcher name: https://github.com/kyma-project/runtime-watcher/blob/main/.github/workflows/build-image.yml#L41

updated code to use the image using the common name

implementation at KLM side is: https://github.com/kyma-project/lifecycle-manager/pull/1868

See the comments wrt. to the issues with e2e tests

verify that it works e2e without -skr suffix

runtime watcher also needs to be updated to pass the new patch. PR for this is here: https://github.com/kyma-project/runtime-watcher/pull/385