There is an existing TODO comment within our codebase that suggests deleting a specific logic block after migrating to modular Kyma. This block is related to the usage of the eventing label. However, a linter analysis flags this as a potential issue, advocating for the code's removal or refactor.
Unfortunately we cannot delete the related lines because: we use the “eventing” label to delete PVCs, and therefore we should not delete it right now.
Description
There is an existing TODO comment within our codebase that suggests deleting a specific logic block after migrating to modular Kyma. This block is related to the usage of the eventing label. However, a linter analysis flags this as a potential issue, advocating for the code's removal or refactor.
Unfortunately we cannot delete the related lines because: we use the “eventing” label to delete PVCs, and therefore we should not delete it right now.
Related code part: https://github.com/kyma-project/nats-manager/blob/5e038645a90b1aed9ec4b96e8c06e87caa77a91c/internal/controller/nats/deprovisioner.go#L125
Reasons
Delete the related logic after migrating to modular Kyma