search

kyma-project / nats-manager

Apache License 2.0
5 stars 13 forks source link

settings for memstorage are not properly passed through to nat-server #72

Closed friedrichwilken closed 5 months ago

friedrichwilken commented 1 year ago

Description If I change an existing nats cr by editiing spec.jetstream.memstorage.enabled, the nats container will log: 

 [29] 2023/06/28 12:09:51.549456 [ERR] Failed to reload server configuration: config reload not 
supported for jetstream dynamic max memory and store

It looks like this cannot be changed after setup, so add validation to the nats cr that will make memstorage immutable.

Further, if spec.jetstream.memstorage.enabled is set to false and the memstorage.size is set to 20Mi, nats server info will show me Max Memory: 5.8 GiB. It looks like this will set the size to -1 and -1 will be interpreted as unlimited. Document that size -1 in nats cr will lead to unlimited and pass the value trough to the cm. enabled=false in the nats cr should set the size to 0 in the cm.

Expected result

Actual result

Steps to reproduce

Troubleshooting

kyma-bot commented 1 year ago

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

You can:

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

grischperl commented 1 year ago

/remove-lifecycle stale

kyma-bot commented 1 year ago

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

You can:

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

kyma-bot commented 12 months ago

This issue or PR has been automatically closed due to the lack of activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

You can:

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

kyma-bot commented 12 months ago

@kyma-bot: Closing this issue.

In response to [this](https://github.com/kyma-project/nats-manager/issues/72#issuecomment-1808086199): >This issue or PR has been automatically closed due to the lack of activity. >Thank you for your contributions. > >This bot triages issues and PRs according to the following rules: >- After 60d of inactivity, `lifecycle/stale` is applied >- After 7d of inactivity since `lifecycle/stale` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle stale` > >If you think that I work incorrectly, kindly [raise an issue](https://github.com/kyma-project/test-infra/issues/new/choose) with the problem. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 5 months ago

This issue has been automatically closed due to the lack of recent activity. /lifecycle rotten