kyma-project / serverless

Apache License 2.0
4 stars 18 forks source link

Serverless integration tests are failing #998

Closed kwiatekus closed 3 months ago

kwiatekus commented 4 months ago

Description

Suddenly your integration tests started to fail: https://github.com/kyma-project/serverless/actions/workflows/integration-tests-push.yaml

I can reproduce the failure locally:

IMG=europe-docker.pkg.dev/kyma-project/prod/serverless-operator:main make install-serverless-custom-operator

make -C tests/serverless serverless-integration
kwiatekus commented 4 months ago
cloning repository: remote repository is empty\n#10: while cloning repository: remote repository is empty","test":"serverless-integration-gitops","time":"2024-05-23T09:21:59Z"}
{"level":"ERROR","timestamp":"2024-05-23T09:21:07Z","caller":"controller/controller.go:329","message":"Reconciler error","context":{"controller":"function-controller","controllerGroup":"serverless.kyma-project.io","controllerKind":"Function","Function":{"name":"python39","namespace":"test-serverless-simple-09h21m07s"},"namespace":"test-serverless-simple-09h21m07s","name":"python39","reconcileID":"b090c75a-7e56-472f-8287-2de5e40c6b23","error":"docker registry configuration not found, configuration secret (serverless-registry-config-default) not found in function namespace: secrets \"serverless-registry-config-default\" not found","errorVerbose":"secrets \"serverless-registry-config-default\" not found\ndocker registry configuration not found, configuration secret (serverless-registry-config-default) not found in function namespace\ngithub.com/kyma-project/serverless/components/serverless/internal/controllers/serverless.(*FunctionReconciler).readDockerConfig\n\t/workspace/go/src/github.com/kyma-project/serverless/components/serverless/internal/controllers/serverless/function_reconcile.go:194\ngithub.com/kyma-project/serverless/components/serverless/internal/controllers/serverless.(*FunctionReconciler).Reconcile\n\t/workspace/go/src/github.com/kyma-project/serverless/components/serverless/internal/controllers/serverless/function_reconcile.go:138\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.5/pkg/internal/controller/controller.go:227\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1695"}}
pPrecel commented 3 months ago

The gitserver that can't receive POST requests from the serverless-mgnr-ctrl. I think the problem occurred after building an image with newer dependencies, so the problem is that the same dependencies are not cooperating ( or new dependencies are not working with old configuration files ).

I've decided to set the gitserver image version to the last working one, so the main branch is unblocked and the tests are functional.

The only problem will be updating the gitserver content (for example changing the function's code or dependencies). In this case, I would suggest creating gitserver from the beginning or maybe finding an alternative because the cost of fixing the actual solution would be too high.

pPrecel commented 3 months ago

I fixed gitserver version to the last working one. For not this is enough but in the future we should focus on fixing/rebuilding the whole gitserver.