[Code Quality] Improve code base semantic linting

kyma-project / telemetry-manager

Manager for the Kyma telemetry module

https://kyma-project.io/#/telemetry-manager/user/README

Apache License 2.0

5 stars 24 forks source link

[Code Quality] Improve code base semantic linting #114

Open a-thaler opened 1 year ago

a-thaler commented 1 year ago

Description

In order to avoid typical mistakes, more linters should be added to our automation

Semantic Linters

interfaces ~~ireturn~~, ~~interfacebloat~~ shadowing, assignment and type errors predeclared, reassign, unconvert testing improvements ~~testpackage~~, ~~paralleltest~~, ~~tparallel~~, ~~thelper~~ naming varnamelen errors wrapping wrapcheck context misuse ~~containedctx~~, ~~contextcheck~~ dependencies management ~~importas~~

Acceptance criteria:

[ ] Linters from the list above are configured and integrated as a part of the code linting stage.
[ ] Code-style changes are agreed upon within the team and documented.
[ ] Codebase is refactored to conform to the new standards.
[ ] The updated linting stage is a part of the CI pipeline.

kyma-bot commented 1 year ago

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

kyma-bot commented 10 months ago

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

kyma-bot commented 7 months ago

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

After 60d of inactivity, lifecycle/stale is applied
After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.