kyma-project / telemetry-manager

Manager for the Kyma telemetry module
https://kyma-project.io/#/telemetry-manager/user/README
Apache License 2.0
5 stars 24 forks source link

Enhance runtime input with selectors for nodes #1300

Open a-thaler opened 1 month ago

a-thaler commented 1 month ago

Description As part of https://github.com/kyma-project/telemetry-manager/issues/972 enhance the current runtime input with a new selector for nodes. It should be disabled by default.

Criterias

Tasks

Reasons

Attachments

Release Notes

a-thaler commented 1 week ago

While implementing the feature we realized a serious problem. The gateway has a really nice feature of enriching all data with the typical resource attributes about the source, in case it is missing. Unfortunately, the new metrics are kubernetes resource specific and a source as this is not existent. In consequence, the resource attributes should not get enriched. In summary, we need a way to disable the enrichment on metric level. Possible solutions are discussed in https://github.com/kyma-project/telemetry-manager/pull/1409.

Most likely we will add a new resource attribute which can be added to your metrics. If the attribute is present, an enrichment will not happen.

So next steps are deciding on the solution and then introduce the conditional switch mechanism

a-thaler commented 2 days ago

The internals of the collector setup got adjusted and in next two weeks the actual feature can be realized on top of it. So the release will be in 2 weeks (not including rollout)