search

kymata-atlas / kymata-core

Core Kymata codebase, including statistical analysis and plotting tools
https://kymata.org
MIT License
5 stars 0 forks source link

Gridsearch refactor - Step 1 - npy-ifying the inv-sols and morphmaps #276

Closed ollieparish closed 2 months ago

ollieparish commented 2 months ago

PR to automatically generate the npy version of the combined inverse-operator + morph-map and apply these instead. Roughly 11 seconds to run load_single_emeg => approx. 3.5 mins for dataloading over all the participants.

Step (1) of #275

Fixes #281

neukym commented 2 months ago

Nice - let me know when you want a reviewer for it.

ollieparish commented 2 months ago

Ok cool, this works now, still takes a while to run - about 30 mins per function (for source space - all participants - default run parameters) but runs. No need to review and merge in right away but feel free to switch to this branch to run stuff a bit faster.

neukym commented 2 months ago

nice - I will test, and sort out the linting 👍

neukym commented 2 months ago

Russian works fine but appears to be labelling the functions wrong: gridsearch_refactor_test_TVL_family_source_russian_14_participants nkg_gridsearch

neukym commented 2 months ago

Will post what English looks like.

neukym commented 2 months ago

Russian_tvl_family

neukym commented 2 months ago

I can confirm d0c95d4 work fixes issue. Speed-up is x3 (for the 11 TVL functions it is just 4.5 hours, down from 10-15).