kymata-atlas / kymata-core

Core Kymata codebase, including statistical analysis and plotting tools
https://kymata.org
MIT License
5 stars 0 forks source link

Fill in correct values for stimulus drift and shift corrections #291

Closed caiw closed 2 months ago

caiw commented 2 months ago

As mentioned in #290, these fields have been added to config files but aren't yet correct:

Note to people doing this

stimulus drift can be done using (trigger == 2)

neukym commented 2 months ago

I added some of these to visual-input-stream.

For tactile, these are set to as none as they are not relevant for the current datasets

neukym commented 2 months ago

Note that audio_delivery_shift_correction is correctly 0.0 for dataset 3 - we have the MISC channel and have confirmed there was no drift (luckily, as I don't think I would have noticed this if there was.).

neukym commented 2 months ago

Interestingly, the config for dataset 3 was incorrect anyway, and had the audio and delivery delays from 4, so good job you put this issue here Cai.

neukym commented 2 months ago

Completed as part of #290, tested and confirmed to mimic previous results.