search

kymata-atlas / kymata-core

Core Kymata codebase, including statistical analysis and plotting tools
https://kymata.org
MIT License
5 stars 0 forks source link

Discuss `test_download_and_delete_fsaverage_surfaces()` #293

Closed neukym closed 3 weeks ago

neukym commented 2 months ago

Hi @Cai - Can we discuss the test test_download_and_delete_fsaverage_surfaces() at some point next week?

It is sensibly testing the downloading of the fsaverage surfaces. I suppose it doesn't matter too much but ... I think this requires it to download 250MB+196MB (i.e almost 0.5GB) by github actions every time we push a commit. I just wanted to make sure that we agreed whether this is sensible.

caiw commented 2 months ago

Interesting - this test makes sure that the reliance on downloading from MNE keeps working, but it seems mad to do this each time we push a commit. Maybe we can somehow split this off into a separate CI action which runs like once a month instead? Or just rely on it breaking for us in use rather than test it with CI.

caiw commented 2 months ago

Can we exclude certain tests from the on-push CI?

Modify args to run: poetry run pytest maybe

neukym commented 3 weeks ago

yes, we can with:

IN_GITHUB_ACTIONS = os.getenv("GITHUB_ACTIONS") == "true"

@pytest.mark.skipif(IN_GITHUB_ACTIONS, reason="Test doesn't work in Github Actions.")
neukym commented 3 weeks ago

Fixed with https://github.com/kymata-atlas/kymata-core/commit/8cdb83549eb0f2de8f6d34f68a3940561a29a015