search

kymata-atlas / kymata-core

Core Kymata codebase, including statistical analysis and plotting tools
https://kymata.org
MIT License
5 stars 0 forks source link

remove `ippm_parameter_evaluation` folder from demos #352

Closed neukym closed 2 months ago

neukym commented 3 months ago

Hi @anirudh1666 and @caiw - I got Kymata to upload automatically to PyPI every time we tag a commit as a release (https://pypi.org/project/kymata/). However, I had to move Anirudh's 2 notebooks to a new folder - demos/ippm_parameter_evaluation, otherwise, they are added to the build. (Because they contain lots of PNG's, they would add considerably to the file size if I hadn't moved them.)

But them being in demos isn't quite right either as their is already a notebook in here that intends to demonstrate how to create an IPPM from the demo data.

Could you both discuss together how best to handle them? They should perhaps be combined and be relabelled something like demo_for_automatic_IPPM_evaluation.

caiw commented 3 months ago

I can look at this as part of #225

anirudh1666 commented 3 months ago

Personally, I think we can keep them locally. The results are out-dated now that we are using the English dataset but the code is still useful for re-usability. You can fix this by deleting them, and I will copy a copy into a different directory before I pull.