70% of CI testing time is spent running `test_download_and_delete_fsaverage_surfaces`

kymata-atlas / kymata-core

Core Kymata codebase, including statistical analysis and plotting tools

https://kymata.org

MIT License

5 stars 0 forks source link

Closed caiw closed 3 months ago

caiw commented 3 months ago

This is possibly also violating some TOS of MNE/OSF, if we're downloading multiple MB of data on each run of the CI.

Consider deleting this test?

Or have a separate CI runner which runs once a day/week on a cron job rather than on every commit to a live PR?

neukym commented 3 months ago

I added these lines above the tests that involve downloading:

@pytest.mark.skipif(
    IN_GITHUB_ACTIONS,
    reason="Test only when run locally - otherwise github will download these each"
    "time we push",
)

This skips these tests when using Github actions.

neukym commented 3 months ago

Confirmation this is working for all three download tests: (s = skip)