Closed caiw closed 11 months ago
@neukym Here's the issue for the thing we discussed just now. Please feel free to add extra things-to-decide at the bottom, and we can discuss them and make decisions at a later date.
Great draft. I can answer one of the above now: we won't need to include bad channels - these will have been interpolated during preprocessing, so we should always have the full array.
Decision: We need L/R info for plotting, but this could be supplied in config files or helper functions, not in the .nkg files themselves.
Decision: sensor names stored in index, with their "MEG", "EEG" prefixes
Decision: load function needs to know if it's loading sensor or source space. this should be stored in the file
Decision: it's just source (with hemispheres) / sensor(without hemis). EEG/MEG/OPM are just examples of sensor data. Don't need to future-proof for ECoG etc.
At the moment,
ExpressionSet
s only deal in source-space (hexel) data. But it's also use to work with sensor-space data, especially as it's much smaller and faster to work with.ExpressionSet
s should therefore expand to incorporate sensor-space data.Things to discuss
ExpressionSet
, we usexarray.DataSet
s to store the ensemble data, with different layers for.left
and.right
. The good news is that if we had a different data structure with a single layer, all the same operations would still work (this is the beauty ofxarray
). However we would need to incorporate this both in to the datastructure, and into the .nkg file format.ExpressionSet
?ExpressionSets
of different channel dimensions can't be added togetherExpressionSet
, sensor and hexel, or is there the possibility for extra versions in the future?