fix attempting to install on python2

kynan / nbstripout

strip output from Jupyter and IPython notebooks

Other

1.19k stars 95 forks source link

fix attempting to install on python2 #129

Closed casperdcl closed 4 years ago

casperdcl commented 4 years ago

The nbstripout==0.3.8 package was not built & released correctly, which means that pip install -U nbstripout will incorrectly install an incompatible version on python2 (e.g. https://github.com/SyneRBI/SyneRBI_VM/issues/169)

This PR fixes this issue in future.

kynan commented 4 years ago

Thanks, good catch! Unfortunately I can no longer fix the "broken" 0.3.8 release, but this will go into the next release.

casperdcl commented 4 years ago

I'd recommend

releasing a new 0.3.9 with py2 support (essentially duplicate of 0.3.7)
releasing a new 0.3.10 with py3 support (essentially the current master)

to ensure anyone running pip install --upgrade in future on either python version doesn't get something incompatible.

kynan commented 4 years ago

That is a good suggestion! Sorry, didn't see this before releasing 0.3.9 last weekend (as a py3 only release). What I really should have done is make 0.4.0 the first py3 only release. Maybe I'll tag a 0.3.10 as a py2 compatible release and then continue with 0.4.0.