search

kynan / nbstripout

strip output from Jupyter and IPython notebooks
Other
1.19k stars 95 forks source link

Pre-commit Jupyter type installation issue. #132

Closed jcmuddle closed 3 years ago

jcmuddle commented 4 years ago

When using nbstripout with pre-commit I experience the following error after running pre-commit autoupdate

Updating https://github.com/kynan/nbstripout ... 
==> File /home/jmuddle/.cache/pre-commit/repokfgntqfa/.pre-commit-hooks.yaml
==> At Hook(id='nbstripout')
==> At key: types
==> At index 0
=====> Type tag 'jupyter' is not recognized.  Try upgrading identify and pre-commit?

This seems to be related to the most recent change to .pre-commit-hooks.yaml.

I resolved the issue by installing the identify library. https://github.com/chriskuehl/identify

This primarily seems to be an issue with pre-commit not installing the necessary dependencies, but it might be useful to update the doc, but at a minimum, this issue might help others.

kynan commented 4 years ago

afaict, pre-commit depends on identify. Do you have a way to reproduce the issue?

kynan commented 3 years ago

@jcmuddle Are you still seeing this issue?

jcmuddle commented 3 years ago

@kynan Sorry for the late reply. I am no longer seeing this issue. Thank you for the work you have put into this tool.