search

kynan / nbstripout

strip output from Jupyter and IPython notebooks
Other
1.19k stars 95 forks source link

fix bugs #138

Closed liangbug closed 3 years ago

liangbug commented 3 years ago

READMe.rst:

No "kernel_spec", only "kernelspec".

_nbstripout.py :

The extra_keys is a byte string, but args.extra_keys is a string. Then ' '.join((extra_keys, args.extra_keys)) got an error.

kynan commented 3 years ago

Thanks for catch the decode() issue on the extra_keys. I was able to reproduce it.

I've since changed the README, so that part of the change is obsolete. I'll rebase your patch on top of master.

kynan commented 3 years ago

Merged in f5eae93