search

kynan / nbstripout

strip output from Jupyter and IPython notebooks
Other
1.19k stars 94 forks source link

Replace cram with prysk #165

Closed kynan closed 1 year ago

kynan commented 2 years ago

Prysk (https://github.com/Nicoretti/prysk) seems to be a new-ish, maintained fork of https://github.com/brodie/cram. Would be good to evaluate if this addresses some of the long-standing issues with cram e.g. Windows newlines.

arobrien commented 1 year ago

@kynan I had a go at getting Prysk to work, and I kept on coming up against issues with the windows builds: https://github.com/arobrien/nbstripout/pull/3

A fundamental issue is having tests which require the bash shell to work in a very specific way.

On the other hand, I had another go at testing git integration using built in pytester fixtures, with good success, I think. I'll do up a PR based on this, and make the bash diff test posix-only: https://github.com/arobrien/nbstripout/blob/arobrien/moretesting/tests/test_git_integration.py

kynan commented 1 year ago

Great progress, thanks!