search

kynan / nbstripout

strip output from Jupyter and IPython notebooks
Other
1.19k stars 94 forks source link

Support config files #169

Open janosh opened 1 year ago

janosh commented 1 year ago

Closes #166.

The code in this PR was adapted from https://github.com/PyCQA/autoflake/pull/79. Big thank you and credit to @akeeman.

kynan commented 1 year ago

Please ensure your changes are compatible with Python 3.6 onwards.

kynan commented 1 year ago

@janosh are you still planning to pick this back up at some point?

janosh commented 1 year ago

@kynan Still pre-occupied. If @arobrien wants to take over, that would be great! 👍

arobrien commented 1 year ago

@janosh and @kynan I've done some work to address the precedence and make other minor improvements. I wasn't sure how to get those edits into the PR, but I've created a PR to update this PR. Please let me know if there is a better way to address this. https://github.com/janosh/nbstripout/pull/1

janosh commented 1 year ago

@arobrien I think the usual approach is just to make a new PR to upstream, i.e. to https://github.com/kynan/nbstripout, not my fork. If you continued from my branch, the earlier commits will still be associated with me. I'm not worried about credit though. More important to get the feature. 😄

Either way, happy to merge your PR to my fork.

kynan commented 8 months ago

@janosh Are you still planning to address the outstanding review comments? :)

janosh commented 8 months ago

Sorry, don't have time. Feel free to close.

kynan commented 8 months ago

Thanks for the update! I'll leave this pending for now. Maybe I'll find time to pick this up myself over the holidays.

l-johnston commented 7 months ago

Will this feature be available in pyproject.toml?

In my use case, I need to filter notebooks that have a specific cell tag while leaving all others unfiltered. Will this feature support this use case?

kynan commented 7 months ago

Will this feature be available in pyproject.toml?

I think this PR was supposed to add pyproject.toml support for configuring nbstripout, yes.

I need to filter notebooks that have a specific cell tag while leaving all others unfiltered. Will this feature support this use case?

I don't think your feature request is related to this PR. Please file a new issue.

@l-johnston would you be interested in working on this PR?