kynan / nbstripout

strip output from Jupyter and IPython notebooks
Other
1.19k stars 94 forks source link

Replace sys.exit() with raise SystemExit #173

Closed janosh closed 1 year ago

janosh commented 1 year ago

Reasoning explained in https://youtu.be/ZbeSPc5wL0g.

Split-out PR following https://github.com/kynan/nbstripout/pull/169#discussion_r985213917.

janosh commented 1 year ago

Realised that we shouldn't be exiting from within functions but simply return.

Was thinking about raising that point too.