search

kynan / nbstripout

strip output from Jupyter and IPython notebooks
Other
1.19k stars 94 forks source link

feat: add option to keep output style #177

Closed davidxia closed 1 year ago

davidxia commented 1 year ago

with nbstripout --keep-metadata-keys or git config key filter.nbstripout.keepmetadatakeys.

closes #78

davidxia commented 1 year ago

Thanks, this mostly LGTM. Tests seem to be failing though, could you please fix?

Updated. Looks like I need to be approved each time to run the tests.

kynan commented 1 year ago

Tests still failing unfortunately :(

davidxia commented 1 year ago

Sorry, fixed and made sure it passes for me locally.

kynan commented 1 year ago

Ugh, test failure is now entirely unrelated to your change, caused by actions/runner-images#6399

kynan commented 1 year ago

"Fixed" in 4ff5477 by dropping 3.6 and adding 3.11 instead. Guess we have to go with the times...

Can you rebase this PR?

kynan commented 1 year ago

Thanks for your contribution!

davidxia commented 1 year ago

thank you!