search

kynikos / wiki-monkey

MediaWiki-compatible bot and editor assistant running directly in the browser and expandable with plugins.
https://github.com/kynikos/wiki-monkey/wiki
GNU General Public License v3.0
15 stars 5 forks source link

Filter for Special:NewPages #157

Closed lahwaacz closed 10 years ago

lahwaacz commented 10 years ago

Since this is my first plugin, I hope I got it right...

Addresses #155

kynikos commented 10 years ago

Merged, thank you!! You've done a fantastic job, I don't know how you've managed to understand how all that works by yourself without asking anything :) If you want to ask how some algorithm works, don't hesitate, it will probably save you time. Also if you want to help fix some other non-straightforward bug you may want to discuss it first, so you don't risk wasting time solving it in a way that wouldn't be the best one, e.g. with #135 ;) Finally, it would be better if you could work on top of the develop branch instead of master, because the configuration files are set differently (on the master branch they're derived from the develop branch when I run src/files/release.py for a stable release), and since I have to merge on my develop branch I have to fix all the conflicts ^^

lahwaacz commented 10 years ago

Well, your code is probably more readable than you think :) I do work on the develop branch, but for the pull request I have to set up another branch to skip some commits (e.g. lahwaacz/wiki-monkey@653e46cd5c29bd258b6da0b8d17f5be4829ba709). But next time I will base this branch also on your develop branch.