search

kynikos / wiki-monkey

MediaWiki-compatible bot and editor assistant running directly in the browser and expandable with plugins.
https://github.com/kynikos/wiki-monkey/wiki
GNU General Public License v3.0
15 stars 5 forks source link

Show bot interface on Special:ProtectedPages #195

Closed lahwaacz closed 9 years ago

lahwaacz commented 9 years ago

Showing bot interface on Special:ProtectedPages would allow to fulfill this request easily. It would also be beneficial to check the list regularly (but infrequently), so this would not be a one-time investment.

Permissions are already checked when processing a page, so this is not a problem. For the regular users there would only be an interface that does nothing, which might lead to some confusion, but I think that the error message in the log would be clear enough.

kynikos commented 9 years ago

Implemented with b86117f8bbf24c14ce16a2cd27e5d347a2a8c040 (forgot to reference this bug from the commit comment, sorry). I know you've got a clone of the repo, you can use it from the develop branch, or do you need a release? (Closing meanwhile)

lahwaacz commented 9 years ago

The release can wait, thanks for the quick implementation!

There is a small bug in that the Wiki Monkey interface is shown above the MediaWiki "Protected pages" box/form, whereas on other pages it is below the form, just above the list.

kynikos commented 9 years ago

Uh, honestly I looked at where I was inserting it in the other pages, and it seemed to me that it was always above any list filters: for example in Special:MostLinkedTemplates, Special:ShortPages and Special:WhatLinksHere/Main_page I always see it above the filters. Where do you see it below the forms/filters?

lahwaacz commented 9 years ago

Well, the first two don't have any "framed" box/form, so Wiki Monkey is naturally at the top. On Special:WhatLinksHere it is between "What links here" and "Filters" frames.

I was looking at Special:AllPages, but admittedly, this piece of code was probably written by me.. :P

kynikos commented 9 years ago

So... is it only in AllPages that it's below the filters? 'Cause maybe in that case it's easier to just put WM above there too :D Unless you think it looks better if it always stays below unframed filters, actually I don't have a real preference for one or the other way...

lahwaacz commented 9 years ago

Ha, found another: Special:PagesWithProp. The problem with Wiki Monkey at the top is that when the framed forms are followed top to bottom, the MediaWiki forms will reload the page and the content of Wiki Monkey's form will be lost. On the other hand, the "page navigation line" (links to "Next 500", numbers of items per page etc) behaves the same way and placing Wiki Monkey below it would be really ugly. I could get used to Wiki Monkey being at the top, it just surprised me this time.

kynikos commented 9 years ago

So your intended "stacking style" would have been to keep the links/forms that reload the page at the top, and the rest (WM) below them? Well, it would indeed make sense, if it wasn't for that unframed "page navigation line" as you say, which definitely has to stay below WM and any other frame. I don't know, I'll think about it a while longer :)

kynikos commented 9 years ago

After reviewing this today I've realized you were right, so I've just moved WM below the native filter in Special:ProtectedPages, like in the other pages.