search

kynikos / wiki-monkey

MediaWiki-compatible bot and editor assistant running directly in the browser and expandable with plugins.
https://github.com/kynikos/wiki-monkey/wiki
GNU General Public License v3.0
15 stars 5 forks source link

Redirects over interwiki links #213

Closed lahwaacz closed 9 years ago

lahwaacz commented 9 years ago

Wiki Monkey can't deal with redirects over interwiki links, e.g. this one. Before I fixed it, the page redirected to this url and Wiki Monkey choked when I wanted to sort interlanguage links on other page. Just thought I'd let you know...

kynikos commented 9 years ago

Thanks, it's fixed now in the develop branch: this should be a rather rare bug, so I don't feel the need to do a release, I think you're using your own fork so you can pull the patch, right? Actually the fix consists in just showing a warning and continuing the execution, leaving the offending interlanguage link as it is: if the redirect uses a real external interwiki link, its target couldn't be checked for interlanguage links anyway; internal/fake interwiki links are peculiar to the ArchWiki, and shouldn't be used in redirects in the first place, so I think issuing a warning is the proper way to fix this :)

lahwaacz commented 9 years ago

Agreed, warning is just fine. Unfortunately there is no way to test this :D and I think there will be many releases before I come across this issue again. Edit: I see that you've already tested the commit, so everything should be fine ;)