search

kyoheiu / felix

tui file manager with vim-like key mapping
https://kyoheiu.dev/felix/
MIT License
729 stars 26 forks source link

Config file creation output is incorrect #142

Closed kdb424 closed 1 year ago

kdb424 commented 1 year ago

Output after upgrading to 2.0 from an older version left me with this message Config file created. See ~/.config/felix/config.yaml This file location is both incorrect, and the extension is now wrong. On Mac, it's ~/Library/Application Support/felix/confix.toml. This value should probably be dynamic and not set in arbitrary text to prevent these sorts of issues in the future.

kyoheiu commented 1 year ago

Thank you for the report. You're right, on my intel mac it showed the path for Unix, though cfg!(target_os = "mac_os") was set. And the process of making config file also had a bug, so fixed it #143

kyoheiu commented 1 year ago

Merged #143, you should now see the right path. Could you check it? (Available via crates.io)

kyoheiu commented 1 year ago

FYI, from v2.0.0 felix uses yaml, so the extension itself is not wrong.

kdb424 commented 1 year ago

Confirmed that it's working. Sorry for mixing up which was which on the file extension, that is correct. Only other note I have on this topic is that ~/Library/Application Support/ is normally used for GUI programs on Mac, where as most command line programs like Vim, emacs, ranger, ect use standard Linux file locations even on Mac, so this may be an extra work on your end to handle Mac, while adding to confusion for users. Personally, I'd prefer that the files were in .config on Mac as all of my other command line tools are likewise there, but V2.0.1 now is working as you intended at least 👍

kyoheiu commented 1 year ago

Excellent! Thank you for checking it out. Another suggestion, I was not aware of that and will consider it.