search

kyoheiu / felix

tui file manager with vim-like key mapping
https://kyoheiu.dev/felix/
MIT License
712 stars 25 forks source link

preview not working with kitty #181

Closed salkin-mada closed 1 year ago

salkin-mada commented 1 year ago

felix v2.2.4 chafa v1.12.4 imagemagick v7.1.0.60 kitty 0.26.5 Arch Linux 6.1.8

When I press v in felix the pointer > and the bottom "infobar" disappears. An the preview is empty. image image

felix preview works just fine with alacritty and foot on the same system.

kyoheiu commented 1 year ago

Thanks, this was apparently bug. Fixed by ad5ca5cb679c51491bf611f07556318de8c0ebca If you'd like to use felix with kitty for now, please git clone develop branch and cargo install --path . for now.

kyoheiu commented 1 year ago

FYI, due to kitty's image drawing structure, felix has to clear and write the entire display for each input if the preview is on, so the user experience is not as good as on other terminals IMO.

salkin-mada commented 1 year ago

Yeah felix feels way more snappy on alacritty. But chafa paints preview images way better in kitty due to its image capabilities.

kyoheiu commented 1 year ago

Wezterm can show detailed image preview, too.

salkin-mada commented 1 year ago

ad5ca5c fixed preview on kitty, nice. Thanks!