search

kyoheiu / felix

tui file manager with vim-like key mapping
https://kyoheiu.dev/felix/
MIT License
708 stars 24 forks source link

Support for Tabby #213

Closed sergiorgiraldo closed 1 year ago

sergiorgiraldo commented 1 year ago

The fix made for Kitty can be applied to Tabby as well

kyoheiu commented 1 year ago

Thank you for the PR. Ah, the terminal-specific issue again... 😂

I have to check after downloading tabby myself, but if tabby has the same issue as kitty, it'd be better to not add new field to State: In fact other terminal could appear to the list, and that would go on forever. So, updating the name of is_kitty to something that indicates the necessity to refresh the screen would be best.

kyoheiu commented 1 year ago

Please focus on one issue at a time. I'll close this for now.

I created CONTRIBUTING.md to clarify the flow, so please check it out.