search

kyoheiu / felix

tui file manager with vim-like key mapping
https://kyoheiu.dev/felix/
MIT License
692 stars 24 forks source link

Enable `Ctrl-h` for Backspace Functionality #252

Closed 0x6b closed 7 months ago

0x6b commented 8 months ago

Hi there, thank you for the great project. I like it in a snap!

I've noticed that, while executing z, i, I, c, and /, removing a character backward, the Ctrl-H does not work as expected while the backspace key does. I have a strong muscle memory for using Ctrl-H as a backspace alternative, this small discrepancy prevents me from using felix smoothly.

I think impact to existing users and complexity the changes will introduce should be minimal. I would be happy to contribute to this enhancement as the changes needed for this looks straightforward. If you agree with this suggestion, I can open a pull request. If not, please just close this issue. Your thoughts and comments would be appreciated. Thanks!

kyoheiu commented 8 months ago

Thank you for the suggestion. Sounds good! I would appreciate if you could make a PR.

0x6b commented 8 months ago

@kyoheiu I really appreciate your quick response. I've opened #254 for you to review. The changes work for me but need your review. Please note that I'm not in a rush to get it merged. Thanks!

0x6b commented 8 months ago

Changed Ctrl-H to Ctrl-h to reduce ambiguity.