Closed balroggg closed 2 years ago
One thing I notice that image preview with sixel has wrong width(around twice smaller).
Thank you for pointing that out!
I didn't realize that previewed images produced by sixel can be cleared with escape sequences, which termion
uses. (FYI, in kitty, high-res images cannot be cleared by them).
And yes, previewed images are a little bit smaller. I don't think it is a huge problem, because unless they are "bigger", they should not break the layout of this app. Do you know if this is rooted in sixel itself, or something goes wrong in this app or viuer?
Anyway, for example in wezterm on my machine, sixel support works very well, so I'm going to add that in the next release.
Yeah, not a big problem. Maybe problem in calculation of width/height, because sixel
more pixel format, not column/row.
Something like that
https://docs.rs/termion/latest/src/termion/sys/unix/size.rs.html#14-28
Created PR #72
I decided to not implement the sixel feature for now: The reason is that with this sixel feature turned on, libsixel must be preinstalled even if you are not using a terminal that supports sixel (without it, felix will not start). I am trying to figure out how to implement hi-res preview without the dynamic dependency.
Ok, I completely forgot about it. It's a little strange, I thought viuer
contains code for work with sixel.
Yeah, actually it seems sixel-sys
or other wrapper crate builds a local version of libsixel, so cargo run
works withoug libsixel preinstalled. That's why I didn't think the preinstall is necessary.
I'll keep this issue open to remind.
Created PR #78 Hi-res image preview will be enabled by this if the terminal supports sixel and libsixel is preinstalled.
Viuer crate has optional sixel feature.
For example, foot terminal emulator show better previews with it.