search

kyokan / bob-wallet

Bob Wallet is a GUI for DNS Record Management and Name Auctions on Handshake. It includes an integrated full node: hsd
https://www.bobwallet.io/
GNU General Public License v3.0
381 stars 91 forks source link

Remove beta notice #606

Closed handshake-enthusiast closed 1 year ago

handshake-enthusiast commented 1 year ago

Is it still beta? As per versioning (2.0.0) it doesn't seem so.

handshake-enthusiast commented 1 year ago

Also does it make sense to at least mention https://github.com/kyokan/bob-wallet/releases in https://github.com/kyokan/bob-wallet/blob/master/CHANGELOG.md?

rithvikvibhu commented 1 year ago

Version numbers don't necessarily indicate the release stage and while Bob is daily driven by many, there could still be issues. For example, in v1, we found that some wallets didn't show the correct seed phrase and the wallet users thought they had backed up was a completely different one that what was used! It was pretty rare and only affected ~2 people, but it's still 2 too many.

https://github.com/kyokan/bob-wallet/blob/master/CHANGELOG.md

Wow that hasn't been updated since 0.5.0! I guess we could get it caught up with the new releases from GitHub release notes (into CHANGELOG's format). Wanna take that up @handshake-enthusiast?

handshake-enthusiast commented 1 year ago

while Bob is daily driven by many, there could still be issues

I can guarantee there are issues 😄 E.g. issues are still reported in Telegram and I had a number of different issues. Bugs are inevitable.

Overall, this software doesn't feel "beta".

Status: This is beta software. As with all wallet GUIs, please use with care, and at your own risk.

My concern is this phrase in the beginning of the repo descripton (in README). I believe the phrase could make an impression to new users that this wallet software is unsafe. So I wanted to make sure it's deliberately kept here and whether it's time to reconsider the project status.

handshake-enthusiast commented 1 year ago

I can fill in CHANGELOG if you want to keep it updated. Though it may be problematic for me to adhere the format of Keep a Changelog, particularly types of changes like Added, Fixed, etc. If you think a simple copy-paste from a release's Changelog with a reference to a corresponding release would work well – I can do it!

Releases descriptions are excellent BTW.

rithvikvibhu commented 1 year ago

My concern is this phrase in the beginning of the repo descripton (in README). I believe the phrase could make an impression to new users that this wallet software is unsafe.

Hm okay what can we replace that sentence with? Also, it might included there for legal reasons, I have no idea. Gonna have to make sure it's okay to change it.

I can fill in CHANGELOG if you want to keep it updated. Though it may be problematic for me to adhere the format of Keep a Changelog, particularly types of changes like Added, Fixed, etc. If you think a simple copy-paste from a release's Changelog with a reference to a corresponding release would work well – I can do it!

Instead of having different styles in the file, we can stick to your original suggestion: linking to the releases page at the top of the file. Easier and we won't have to rewrite for past (and future) notes.

handshake-enthusiast commented 1 year ago

This is very strange, but I can't update the PR after the fork deletion even if I start with the same HEAD. I'll just close this PR to proceed in a new one.