kyonifer / koma

A scientific computing library for Kotlin. https://kyonifer.github.io/koma
Other
270 stars 23 forks source link

Fix transitive dependency on xchart #109

Closed drmoose closed 2 years ago

drmoose commented 3 years ago

koma.figures' declared type is Array<Triple<XYChart, JFrame, Int>>>, but xchart in the dependency list is included as implementation, which causes the following compile error:

e: /path/to/your.kt: (285, 36): Cannot access class 'org.knowm.xchart.XYChart'. Check your module classpath for missing or conflicting dependencies

It's possible to work around this locally by adding implementation "org.knowm.xchart:xchart:3.5.1" to my project's build.gradle, but I believe the change proposed in this PR will cause gradle to automatically bring in that transitive dependency and eliminate the error.