kyonifer / koma

A scientific computing library for Kotlin. https://kyonifer.github.io/koma
Other
270 stars 23 forks source link

Add a Matrix Validation Utility #2

Closed drmoose closed 8 years ago

drmoose commented 8 years ago

Because there is no way to validate matrices at compile time, functions which take a Matrix<Double> as their parameter must inspect the dimensions, symmetry, and bounds of that matrix and throw a runtime exception if the given matrix is not valid for the context. This pull request provides a reusable validation DSL that generate detailed, consistent exceptions for matrix parameters in function calls. The functionality is documented in the accompanying README.

drmoose commented 8 years ago

It's now pretty clear this needs either a rewrite or a heavy editing pass. Would you prefer that as additional commits on this branch, or a separate PR with rewritten history?

kyonifer commented 8 years ago

You should be able to squash on this PR and have the PR update.